refactor: use default FastAPI handler instead of custom ORJSONResponse

daryllimyt · daryllimyt · commit 5bb40bb12f4b · 2026-04-20T14:12:11.000-04:00
diff --git a/tracecat/api/common.py b/tracecat/api/common.py
@@ -1,4 +1,5 @@
 from fastapi import HTTPException, Request, Response, status
+from fastapi.exception_handlers import http_exception_handler as default_http_handler
 from fastapi.responses import ORJSONResponse
 from fastapi.routing import APIRoute
 from sqlalchemy import select
@@ -39,27 +40,20 @@ def generic_exception_handler(request: Request, exc: Exception) -> Response:
     )
 
 
-def http_exception_handler(request: Request, exc: Exception) -> Response:
+async def http_exception_handler(request: Request, exc: Exception) -> Response:
     """Log HTTP exceptions with tenant context for observability."""
-    if not isinstance(exc, HTTPException):
-        return ORJSONResponse(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            content={"detail": str(exc)},
-        )
+    http_exc = exc if isinstance(exc, HTTPException) else HTTPException(500, str(exc))
     role = ctx_role.get()
-    log_method = logger.warning if exc.status_code < 500 else logger.error
+    log_method = logger.warning if http_exc.status_code < 500 else logger.error
     log_method(
         "HTTP error",
-        status_code=exc.status_code,
-        detail=exc.detail,
+        status_code=http_exc.status_code,
+        detail=http_exc.detail,
         path=request.url.path,
         method=request.method,
         role=role,
     )
-    return ORJSONResponse(
-        status_code=exc.status_code,
-        content={"detail": exc.detail},
-    )
+    return await default_http_handler(request, http_exc)
 
 
 def bootstrap_role(organization_id: OrganizationID | None = None) -> Role:
