Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass req to getProxyForUrl callback #353

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

lukekarrys
Copy link
Collaborator

@lukekarrys lukekarrys commented Dec 6, 2024

Same as #326 with one minor change in 869ecbc to keep the optionality of the constructor and getProxyForUrl arguments to keep TypeScript happy.

Closes #326.

addaleax and others added 2 commits December 6, 2024 10:12
This allows more flexibility in the callback, e.g. for inspecting
request headers before deciding on a given proxy.
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Dec 6, 2024 5:14pm

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 869ecbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
proxy-agent Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukekarrys lukekarrys changed the title lk/mongodb js req to proxy url Pass req to getProxyForUrl callback Dec 6, 2024
@lukekarrys lukekarrys merged commit 96b771b into main Dec 6, 2024
14 checks passed
@lukekarrys lukekarrys deleted the lk/mongodb-js-req-to-proxy-url branch December 6, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants