Fix compatibility with Node.js 14#104
Merged
TooTallNate merged 1 commit intoTooTallNate:masterfrom Jul 28, 2020
Merged
Conversation
If the socket is writable, a write is attempted and an `ERR_SOCKET_CLOSED` error is emitted because the socket was never connected. Refs: nodejs/node#32272
lpinca
force-pushed
the
fix/compatibility-with-nodejs-14
branch
from
122e416 to
450237e
Compare
2 tasks
Contributor
Author
|
Friendly ping. |
4 tasks
Owner
|
Thank you! |
Contributor
Author
|
@TooTallNate can you please cut a new release? |
|
Hi! Ran into this while testing, will it be possible to cut a release with this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the socket is writable, a write is attempted and an
ERR_SOCKET_CLOSEDerror is emitted because the socket was neverconnected.