This repository was archived by the owner on May 5, 2023. It is now read-only.
use opts.host instead of host#65
Merged
Kikobeats merged 1 commit intoTooTallNate:masterfrom Jun 28, 2021
jumoog:opts_host
Merged
use opts.host instead of host#65Kikobeats merged 1 commit intoTooTallNate:masterfrom jumoog:opts_host
Kikobeats merged 1 commit intoTooTallNate:masterfrom
jumoog:opts_host
Conversation
Collaborator
|
In which scenarios |
Contributor
Author
|
|
Collaborator
Contributor
Author
|
Okay, I'll keep looking. But with this change my code runs again. |
Contributor
Author
|
for the test its i did it like TooTallNate/node-proxy-agent@cd18ccf |
Contributor
Author
|
should split it in to PRs? |
Collaborator
|
yea, split it into two tests, please! |
Contributor
Author
|
Okay now I know what happens. Without opts.host the IP address is used and then when I try to connect HTTPS an openssl error occurs and the program crashes. Because of the crash also appears the warning DEP0123 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62