fix: make opts.host work again (#96)

richardkazuomiller · Kikobeats · web-flow · commit eb87f6c27b06 · 2022-05-31T13:14:24.000+02:00
* fix: make opts.host work again

* Update package.json

* Update package.json

Co-authored-by: Kiko Beats &lt;josefrancisco.verdu@gmail.com&gt;
diff --git a/package.json b/package.json
@@ -113,10 +113,10 @@
     "@types/node": "latest",
     "cacheable-lookup": "^6.0.4",
     "conventional-github-releaser": "latest",
-    "dns2": "^2.0.1",
+    "dns2": "latest",
     "finepack": "latest",
     "git-authors-cli": "latest",
-    "mocha": "latest",
+    "mocha": "9",
     "nano-staged": "latest",
     "npm-check-updates": "latest",
     "prettier-standard": "latest",
diff --git a/src/index.ts b/src/index.ts
@@ -8,6 +8,11 @@ import net from 'net'
 import tls from 'tls'
 
 interface BaseSocksProxyAgentOptions {
+  /**
+   * hostname is preferred over host
+   * 
+   * @deprecated
+   */
   host?: string | null;
   port?: string | number | null;
   username?: string | null;
@@ -25,10 +30,10 @@ function parseSocksProxy (opts: SocksProxyAgentOptions): { lookup: boolean, prox
   let lookup = false
   let type: SocksProxy['type'] = 5
 
-  const host = opts.hostname
+  const host = opts.hostname || opts.host
 
   if (host == null) {
-    throw new TypeError('No "host"')
+    throw new TypeError('No "hostname"')
   }
 
   if (typeof opts.port === 'number') {
@@ -110,7 +115,7 @@ const normalizeProxyOptions = (input: string | SocksProxyAgentOptions): SocksPro
     proxyOptions = input
   }
   if (proxyOptions == null) {
-    throw new TypeError('a SOCKS proxy server `host` and `port` must be specified!')
+    throw new TypeError('a SOCKS proxy server `hostname` and `port` must be specified!')
   }
 
   return proxyOptions
