Enabled OSGi metadata in MANIFST-MF for created JAR #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Toni <[email protected]>
…agement` Signed-off-by: Victor Toni <[email protected]>
Signed-off-by: Victor Toni <[email protected]>
…maven-plugin` Signed-off-by: Victor Toni <[email protected]>
marci4
reviewed
Feb 25, 2020
marci4
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
pom.xmlso that the OSGi metadata is created and included in the resulting JAR.Description
Added the
bnd-maven-pluginand its configuration to thepom.xmlso that resulting JAR will contain OSGi metadata.Related Issue
Fixes #822 .
Motivation and Context
Enables usage of the library in OSGi without the requiring the user to wrap the library.
How Has This Been Tested?
The library JAR still gets created.
Types of changes
Checklist:
(The same failing tests as before the change are still failing afterwards...)