Skip to content

Provide a way to access the SSLSession of a websocket instance #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marci4 merged 5 commits into from
Aug 13, 2019
Merged

Provide a way to access the SSLSession of a websocket instance #893

marci4 merged 5 commits into from
Aug 13, 2019

Conversation

@marci4
Copy link
Collaborator

@marci4 marci4 commented May 20, 2019 •
edited
Loading

Description

There is currently no good way to access the SSLSession used for a websocket.
Therefore it is not possible to examine client certificates

Related Issue

Fixes #890

Motivation and Context

Clean methods to access the SSLSession.

How Has This Been Tested?

Manual test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 self-assigned this May 20, 2019
@marci4 marci4 mentioned this pull request May 20, 2019
Closed
marci4 added 2 commits May 20, 2019 21:08
@marci4
Test development
e351a29
@marci4
Rework after review
95a10ec 
Use IllegalStateException instead of IllegalArgumentException
@marci4 marci4 added this to the Release 1.4.1 milestone Jun 26, 2019
@marci4 marci4 requested a review from PhilipRoman July 10, 2019 20:51
PhilipRoman
PhilipRoman requested changes Jul 10, 2019
View reviewed changes
@marci4 marci4 merged commit 9709433 into TooTallNate:master Aug 13, 2019
@marci4 marci4 deleted the SSLEngine branch August 13, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees

@marci4 marci4

Labels

New Feature wss

Projects

None yet

Milestone

Release 1.4.1

Development

Successfully merging this pull request may close these issues.

Would like to get SSLSession from WebSocket on server to examine client certificates

2 participants

@marci4 @PhilipRoman