Add test for connectBlocking cleanup (#1399) #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipRoman
force-pushed
the
connect_blocking_cleanup_test
branch
from
d80369a to
76a1409
Compare
PhilipRoman
force-pushed
the
connect_blocking_cleanup_test
branch
from
76a1409 to
acd03d0
Compare
Collaborator
Author
|
Interesting - on my local computer the state of client socket remains NOT_YET_CONNECTED, but on GitHub CI it is CLOSED. Most probably due to difference in execution speed. Hopefully it is not an actual race condition (although at this point I don't care - wrong ReadyState is the least of our problems right now) |
Collaborator
|
@PhilipRoman you want me to merge this? |
Collaborator
Author
|
whoops completely forgot about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I wanted to simulate a real network interruption via TCP proxy, but I don't see any case where it would act differently to just ignoring the socket completely. As expected, the test fails on previous versions, without the fix in #1399