PermessageDeflate should handle uncompressed messages #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipRoman
approved these changes
Jul 27, 2021
src/main/java/org/java_websocket/extensions/permessage_deflate/PerMessageDeflateExtension.java
Show resolved
Hide resolved
|
Hi, Thanks for the fix! By the way, what exactly did you mean by example application? This is my first time reporting an issue in open source repository and I think I misunderstood what you meant by 'example application'. Are there any links that I can refer to? Best Regards, |
Collaborator
|
@SaraHan774 "Example application" means a (small) program using this library that makes the issue visible. This saves time for developers, because they don't have to spend time trying to reproduce the bug and can just run the provided application to see the issue. |
|
Thank you for the answer. I will keep that in mind next time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PerMessageDeflate messages may be uncompressed and should therefore not fail
Related Issue
Fixes #1164
Motivation and Context
Bugfix
How Has This Been Tested?
Manual test was not possible since the reporter did not include an example application
Types of changes
Checklist: