Repository navigation
Propagate JAX worker failures and validate launch topology - #496
Merged
Toni-SM merged 2 commits intoNov 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher returned success for a training process that exited nonzero and could fail with an IndexError for a negative node rank. Propagate the worker exit status, reject invalid world sizes and ranks during argument parsing, validate coordinator ports, split the port after the last colon so bracketed IPv6 addresses work, and avoid overwriting the application multiprocessing start method. Three unittest regressions passed, including a real spawned Python worker exiting with status 7.