Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Distributed gradient reduction uses
view(-1), which cannot flatten noncontiguous gradients such as channels-last convolution weights. Flatten withreshapebefore reduction. A real two-worker CPU Gloo regression verifies averaged gradients and preserves the original channels-last gradient layout.Validation
The new regression fails on the unchanged base.
pytest -q tests/utils/model_instantiators/torch: 46 passed with the fix. Fullpre-commit run --all-filesandgit diff --checkpassed.CPU tests on Python 3.12.14 and PyTorch 2.15.0; the complete Torch model-instantiator directory was exercised. No complete multi-backend project-suite claim.
Validation was performed on base
e43d04d4e7eba068016a341f2fdbe3eeef97b70f.