CI: workflow_dispatch - #2160
Merged
Merged
Conversation
casperdcl
requested review from
MargaretDuff and
lauramurgatroyd
and removed request for
a team
May 15, 2025 13:20
lauramurgatroyd
requested changes
May 20, 2025
Comment on lines
99
to
100
| echo "python-version=['3.10', 3.11]" >> $GITHUB_OUTPUT | ||
| echo "numpy-version=[1.23, 1.24, 1.25, 1.26]" >> $GITHUB_OUTPUT |
Member
There was a problem hiding this comment.
Are these versions correct?
Member
There was a problem hiding this comment.
Especially the ones below, under else?
Member
Author
There was a problem hiding this comment.
Please open a separate issue/PR if you want to change them
Member
There was a problem hiding this comment.
do you agree they are incorrect? Otherwise the issue would be wrong
Comment on lines
99
to
100
| echo "python-version=['3.10', 3.11]" >> $GITHUB_OUTPUT | ||
| echo "numpy-version=[1.23, 1.24, 1.25, 1.26]" >> $GITHUB_OUTPUT |
Member
There was a problem hiding this comment.
do you agree they are incorrect? Otherwise the issue would be wrong
| Details on some of these jobs are given below. | ||
|
|
||
| > [!TIP] | ||
| > To skip tests, include [one of the following](https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/skipping-workflow-runs) in your commit message: `[skip ci]`, `[ci skip]`, `[no ci]`, `[skip actions]` or `[actions skip]`. |
Member
There was a problem hiding this comment.
Suggested change
| > To skip tests, include [one of the following](https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/skipping-workflow-runs) in your commit message: `[skip ci]`, `[ci skip]`, `[no ci]`, `[skip actions]` or `[actions skip]`. | |
| > To skip tests, include [one of the following](https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/skipping-workflow-runs) in your commit message: `[skip ci]`, `[ci skip]`, `[no ci]`, `[skip actions]` or `[actions skip]`. However, for merging into CIL master, we must see the tests pass. |
This reverts commit e16c5ee.
casperdcl
force-pushed
the
revert-weird-ci
branch
from
May 27, 2025 08:55
d5181d2 to
51fd64f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👉 diff sans whitespace
Note
You won't see the web UI button before this PR is merged.