Switch to ASTRA direct_FP3D/BP3D interface - #2134
Merged
Merged
Conversation
Member
|
This was waiting for us to update our supported ASTRA versions. I think we have now, so it should be easy to update and include. Thank you for the contribution @wjp, are you happy for me top take to over and make the changes needed for CIL? |
Contributor
Author
|
Hi Gemma, certainly! |
gfardell
added
the
community-contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch the Astra wrapper to use Astra's
direct_FP3Danddirect_BP3Dfunctions for 3D Astra geometries. These functions provide a more concise interface and avoid unnecessary data copies.This interface is supported from Astra 2.0. Starting from Astra 2.3, these functions also transparently accept DLPack tensors (including torch cpu/cuda tensors).
Example Usage
All unit tests pass for me. This is a result from the CIL PyTorch integration hackathon, and has therefore only seen limited further testing.