add pip required & optional dependencies - #2118
Merged
Merged
Conversation
casperdcl
force-pushed
the
pyproject-deps
branch
2 times, most recently
from
March 26, 2025 11:01
6a486a6 to
668bc0c
Compare
casperdcl
commented
Mar 26, 2025
casperdcl
added
enhancement
purepani
reviewed
Mar 26, 2025
This comment was marked as resolved.
This comment was marked as resolved.
casperdcl
added a commit
that referenced
this pull request
Mar 26, 2025
Requires `pip>25.0.1`. See also: - https://peps.python.org/pep-0735/ - pypa/pip#13065 - #2118 (comment)
purepani
reviewed
Mar 26, 2025
purepani
reviewed
Mar 26, 2025
purepani
approved these changes
Mar 28, 2025
purepani
left a comment
purepani
left a comment
Collaborator
There was a problem hiding this comment.
I'll go ahead and approve this since it looks like a fairly good first step.
I'm a bit worried about the duplicated dependencies everywhere, but that can be fixed incrementally!
purepani
self-requested a review
March 28, 2025 16:39
purepani
suggested changes
Mar 28, 2025
casperdcl
added a commit
that referenced
this pull request
Apr 1, 2025
Requires `pip>25.0.1`. See also: - https://peps.python.org/pep-0735/ - pypa/pip#13065 - #2118 (comment)
casperdcl
force-pushed
the
pyproject-deps
branch
from
April 1, 2025 13:24
6b6d567 to
6c87531
Compare
Requires `pip>25.0.1`. See also: - https://peps.python.org/pep-0735/ - pypa/pip#13065 - #2118 (comment)
casperdcl
force-pushed
the
pyproject-deps
branch
from
April 1, 2025 13:27
6c87531 to
87d02f7
Compare
This was referenced Apr 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: moving towards being able to
pip install cil[gpu],pip install . --group test, etc.zenodo_getdependency and unit test errors #2074 (related: Remove change ofImportErrormessage for optional dependencies #2104)--groupoption for installing from[dependency-groups]found inpyproject.tomlfiles pypa/pip#13065 being released inpip>25.0.1Testing
pip install "cil[gpu]@git+https://github.com/TomographicImaging/CIL@pyproject-deps"should say "Requirement already satisfied" for everything.Documentation
This PR is a stepping stone (and also will only become fully useful after the next
piprelease). Docs will be tackled later in #1875.