SAPYB for block data container can take None - #2008
Merged
Merged
Conversation
Member
Author
|
Need to update the docstrings and add to new format |
gfardell
approved these changes
Dec 13, 2024
paskino
reviewed
Jan 9, 2025
paskino
approved these changes
Jan 9, 2025
Co-authored-by: Edoardo Pasca <[email protected]> Signed-off-by: Margaret Duff <[email protected]>
Signed-off-by: Margaret Duff <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Allow SAPYB for the block container to take
out=Noneby creating an out, if needed, the same shape as the containery.SAPYB for the block container now also always returns
Testing you performed
Related issues/links
Closes #1997
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.