Direct method of BlockOperator returns a single DataContainer if the output shape is (1,1) - #1802
Merged
MargaretDuff merged 7 commits intoMay 13, 2024
Conversation
MargaretDuff
marked this pull request as ready for review
May 10, 2024 10:24
MargaretDuff
added
Waiting for review
bug
paskino
approved these changes
May 10, 2024
paskino
left a comment
paskino
left a comment
Contributor
There was a problem hiding this comment.
Please add to the CHANGELOG
- Bugfix:
- BlockOperator that would return a BlockDataContainer of shape (1,1) now return the appropriate DataContainer. BlockDataContainer direct and adjoint methods accept DataContainer as parameter x.
Signed-off-by: Margaret Duff <[email protected]>
samdporter
suggested changes
May 10, 2024
samdporter
left a comment
samdporter
left a comment
Contributor
There was a problem hiding this comment.
The direct method looks good but in PR #1766 the range and domain geometries also returned a regular DataContainer if necessary. This would also be nice otherwise the range_geometry may be different to the geometry of the object returned by direct()
casperdcl
approved these changes
May 13, 2024
Co-authored-by: Casper da Costa-Luis <[email protected]> Signed-off-by: Margaret Duff <[email protected]>
Member
Author
|
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
See #1455
Testing you performed
Related issues/links
Fixes #1455
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.
--->