Step-size methods and preconditoners for GD - #1768
Merged
MargaretDuff merged 47 commits intoMay 24, 2024
Merged
Conversation
Signed-off-by: Margaret Duff <[email protected]>
…ners and step-sizes
MargaretDuff
marked this pull request as ready for review
May 2, 2024 15:22
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
reviewed
May 22, 2024
paskino
approved these changes
May 22, 2024
paskino
left a comment
Contributor
There was a problem hiding this comment.
I suggest to remove a couple of else statements, but other than that it looks good to me|!
Member
Author
|
Closes #1817 |
epapoutsellis
approved these changes
May 23, 2024
Signed-off-by: Margaret Duff <[email protected]>
Member
Author
Signed-off-by: Margaret Duff <[email protected]>
Contributor
|
Thanks a lot all! Yet another major milestone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently a draft for discussion purposes
TODO:
Changes
Added step-size methods and preconditioners for GD
Testing you performed
Related issues/links
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.
--->