WaveletOperator fixes for odd-sized inputs and 1D (VectorGeometry) - #1627
Merged
paskino merged 3 commits intoDec 18, 2023
Merged
WaveletOperator fixes for odd-sized inputs and 1D (VectorGeometry)#1627paskino merged 3 commits into
WaveletOperator fixes for odd-sized inputs and 1D (VectorGeometry)#1627paskino merged 3 commits into
Conversation
VectorGeometry)WaveletOperator fixes for odd-sized inputs and 1D (VectorGeometry)
Contributor
|
@tommheik I will merge this into https://github.com/TomographicImaging/CIL/tree/wavelet_regularisation which is the wip branch. So far I implemented the I didn't do anything on the operator yet, which is the next step. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe changes
adjoint, after the PyWavelet reconstruction, the array is always cut to correct size in case thedomain_geometryis of odd size. The tuple of slicesorg_sizecould be created during initialization as well.range_geometryfor 1D (VectorGeometry) data, the correct shape parameters are given.Describe any testing you have performed
WaveletOperatorshould have a proper tests built at some point because there are so many things that can go wrong. For exampleLink relevant issues
axesfor choosing the dimensions the operator acts on, there should be string-basedcorrelationparameter which would define theaxessimilar toGradientOperatorChecklist when you are ready to request a review