Skip to content

ApproximateGradientSumFunction class and example SGFunction for Stochastic Gradient Descent - #1550

Merged
MargaretDuff merged 183 commits into
TomographicImaging:masterfrom
MargaretDuff:SGD
Mar 26, 2024
Merged

ApproximateGradientSumFunction class and example SGFunction for Stochastic Gradient Descent #1550
MargaretDuff merged 183 commits into
TomographicImaging:masterfrom
MargaretDuff:SGD

Conversation

@MargaretDuff

@MargaretDuff MargaretDuff commented Oct 25, 2023

Copy link
Copy Markdown
Member

Describe your changes

Added the ApproximateGradientSumFunction class and example SGFunction for Stochastic Gradient Descent and relevant unit tests

Describe any testing you have performed

See code

Link relevant issues

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

Comment thread docs/source/optimisation.rst Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/SGFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/SGFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/SGFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/SGFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/ApproximateGradientSumFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/SGFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/SGFunction.py Outdated
Comment thread Wrappers/Python/cil/optimisation/functions/SGFunction.py Outdated
@MargaretDuff

Copy link
Copy Markdown
Member Author

Jenkins is happy
image

@MargaretDuff
MargaretDuff dismissed jakobsj’s stale review March 26, 2024 12:27

Changes made and checked with Edo

@MargaretDuff
MargaretDuff merged commit 040f214 into TomographicImaging:master Mar 26, 2024
@MargaretDuff
MargaretDuff deleted the SGD branch March 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Stochastic Gradient Descent (SGD) Implement SubsetSumFunction

6 participants