Skip to content

Spdhg unit tests - speed up - #1500

Closed
MargaretDuff wants to merge 4 commits into
TomographicImaging:masterfrom
MargaretDuff:SPDHG_unit_tests
Closed

Spdhg unit tests - speed up #1500
MargaretDuff wants to merge 4 commits into
TomographicImaging:masterfrom
MargaretDuff:SPDHG_unit_tests

Conversation

@MargaretDuff

Copy link
Copy Markdown
Member

Describe your changes

Reduced image dimension, max iterations and update objective interval in order to speed up the Spdhg unit tests. Changing to GPU didn't seem to have any speed up locally.

Describe any testing you have performed

Please add any demo scripts to CIL-Demos/misc/

Link relevant issues

#1496

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff
MargaretDuff requested a review from paskino August 30, 2023 11:59
@MargaretDuff

Copy link
Copy Markdown
Member Author

Replaced by #1498

@MargaretDuff MargaretDuff mentioned this pull request Jan 10, 2024
8 tasks
@casperdcl
casperdcl force-pushed the master branch 3 times, most recently from a910556 to f8b513b Compare September 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant