Skip to content

Cupy array - #1126

Draft
paskino wants to merge 16 commits into
TomographicImaging:masterfrom
paskino:cupy_array
Draft

Cupy array#1126
paskino wants to merge 16 commits into
TomographicImaging:masterfrom
paskino:cupy_array

Conversation

@paskino

@paskino paskino commented Jan 20, 2022

Copy link
Copy Markdown
Contributor

Enables a cupy backend for the array wrapped in the DataContainer.

Updates code and unit tests accordingly.

@paskino
paskino marked this pull request as draft January 20, 2022 09:28
@paskino

paskino commented Jan 20, 2022

Copy link
Copy Markdown
Contributor Author

I have avoided to add the backend into the geometry, because it is not really where it belongs. However when methods such as allocate is called, one needs to specify the backend required.

For instance, most operators will internally allocate some datacontainer using the default allocate call, which defaults to the numpy backend. This means that one needs to add an additional member backend to the operator, so that the call to allocate can have a non default choice of backend.

Conversely, if we specify the backend in the geometry, it would be possible to not be forced to add the backend into any operator/function because it could be determined by checking both the geometry and the actual data array.

@paskino paskino added this to the Future Version milestone Mar 24, 2022
@paskino paskino added the discussion This is a discussion thread for enhancements label Apr 25, 2022
@paskino
paskino requested review from epapoutsellis and gfardell and removed request for epapoutsellis and gfardell April 25, 2022 21:20
@paskino paskino mentioned this pull request Jan 17, 2024
@casperdcl
casperdcl force-pushed the master branch 3 times, most recently from a910556 to f8b513b Compare September 2, 2024 13:11
@casperdcl casperdcl mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussion This is a discussion thread for enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant