Repository navigation
Commit 31ead71
authored
fix(trace): aggregate a trace's events outside
When Maglev's code for `aggregate` bails out after V8 switched into it
partway through the loop over the trace's events, Node.js 24's V8 rebuilds
the object `aggregate` returns with its floating-point field shared across
calls. A later trace's duration then overwrites an earlier one's, so a diff's
base side reported the current side's duration. The loop now runs in its own
method, so V8 never switches into `aggregate` mid-loop.
See nodejs/node#66457aggregate to avoid a Node.js 24 V8 bug (#838)1 parent 54f4fe1 commit 31ead71
1 file changed
Lines changed: 13 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
| 337 | + | |
341 | 338 | | |
342 | 339 | | |
343 | 340 | | |
| |||
367 | 364 | | |
368 | 365 | | |
369 | 366 | | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
370 | 379 | | |
371 | 380 | | |
372 | 381 | | |
| |||
0 commit comments