fix: handle case when parsed.name is single item#720
Merged
TomBursch merged 1 commit intoTomBursch:mainfrom Apr 23, 2025
Merged
fix: handle case when parsed.name is single item#720TomBursch merged 1 commit intoTomBursch:mainfrom
TomBursch merged 1 commit intoTomBursch:mainfrom
Conversation
TomBursch
approved these changes
Apr 23, 2025
w0s1nsk1
added a commit
to w0s1nsk1/kitchenowl
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #719
If you can reproduce the problem, we can pass the problem on to the maintainer of IngredientParser, that only one list will be returned in the future.
I removed your length-check because an empty list is evaluated as False, so
if parsed.nameis only True if the list is not empty. With the belownlpAmountToDescriptioni hadn't a problem yet