Merged
Conversation
Owner
|
This looks really good already!
I think we can just leave them in the past and show yesterday above them or the actual date if they're older. Do you know why the data migration fails? It looks good to me. Maybe you need to split up the batch alter table into two (like here for example) |
Collaborator
Author
|
Do you have a chance to check the data migrations? |
692458b to
eca2ec8
Compare
TomBursch
approved these changes
Mar 30, 2025
Owner
TomBursch
left a comment
There was a problem hiding this comment.
Thanks for this. I've only changed some minor things and fixed the migration.
w0s1nsk1
added a commit
to w0s1nsk1/kitchenowl
that referenced
this pull request
Feb 20, 2026
Co-authored-by: Tom Bursch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cooking_date) with typeDateTimewithout timezone and discarded thedayfield. If the API receivesdaythough from older apps, it will be transformed intocooking_date.datetime.now()theoretically more easy, the time is always set to 23:59:59. In the future, time could be used to differ between breakfast, lunch, etc.TODO
day-logic, old recipes could be reset to the future by adding +7 days.