Assorted fixes to improve test stability#2
Merged
TimvdLippe merged 9 commits intoTimvdLippe:pending-preload-response-candidatefrom Jan 4, 2026
Merged
Conversation
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
…d events. Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
jdm
commented
Jan 4, 2026
| expected: FAIL | ||
|
|
||
| [Loading font (anonymous) with link (use-credentials) should discard the preloaded response] | ||
| expected: FAIL |
TimvdLippe
merged commit 75609fb
into
TimvdLippe:pending-preload-response-candidate
20 of 21 checks passed
TimvdLippe
pushed a commit
that referenced
this pull request
Mar 25, 2026
This partially reverts 017b12a. The intermittent issues should be resolved now. ./mach build --release results in ~3GiB of sccache size locally. Since we build multiple configurations (with crown, tests, profiles) we will easily hit the 10GiB cache limit even with just one architecture. Hence, it doesn't make sense to add sccache to more workflows, at least not before we decide to buy more cache or not. This should hopefully make the macos-arm64 workflows faster. Locally the speed-up on clean builds is significant. Testing: [mach try (no existing cache)](https://github.com/jschwe/servo/actions/runs/23507308462/job/68418624068), [mach try #2](https://github.com/jschwe/servo/actions/runs/23508733572/job/68423715413) - i.e. 34 minutes vs. 19 minutes total runtime, and 30 m vs 15 m build time (with ideal conditions for the caching) Signed-off-by: Jonathan Schwender <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All browsers except Firefox fail the
Loading fetch (same-origin) with link (same-origin)andLoading fetch (anonymous) with link (anonymous) should reuse the preloaded responsesubtests in preload-resource-match.https.html (https://wpt.fyi/results/preload/preload-resource-match.https.html?label=master&label=experimental&aligned&q=%2Fpreload%2Fpreload-resource-match.https.html). This is caused by incorrect test code; when a<link crossorigin=anonymous>or<link>makes a request, they will never use theomitCORS mode (https://html.spec.whatwg.org/multipage/urls-and-fetching.html#create-a-potential-cors-request). The fetch() usage in the test needs to account for that, otherwise the preload entry can never be reused.