Skip to content

Enable current domain on dense arrays.#5303

Merged
teo-tsirpanis merged 5 commits intodevfrom
dstara/sc-54482/support-current-domain-for-dense-arrays
Oct 15, 2024
Merged

Enable current domain on dense arrays.#5303
teo-tsirpanis merged 5 commits intodevfrom
dstara/sc-54482/support-current-domain-for-dense-arrays

Conversation

@DimitrisStaratzis
Copy link
Copy Markdown
Contributor

@DimitrisStaratzis DimitrisStaratzis commented Sep 12, 2024

This PR enables the current domain feature in dense arrays


TYPE: FEATURE
DESC: Support current domain on dense arrays.

@DimitrisStaratzis DimitrisStaratzis marked this pull request as draft September 12, 2024 17:13
@DimitrisStaratzis DimitrisStaratzis marked this pull request as ready for review September 12, 2024 17:15
@DimitrisStaratzis DimitrisStaratzis changed the title Enable current domain for Dense. Enable current domain on dense arrays. Sep 12, 2024
Copy link
Copy Markdown
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update documentation in tiledb\api\c_api\array_schema\array_schema_api_experimental.h.

@DimitrisStaratzis
Copy link
Copy Markdown
Contributor Author

You should also update documentation in tiledb\api\c_api\array_schema\array_schema_api_experimental.h.

Done, thanks!

Copy link
Copy Markdown
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread test/src/test-cppapi-current-domain.cc Outdated
Comment thread test/src/test-cppapi-current-domain.cc Outdated
@KiterLuc
Copy link
Copy Markdown
Contributor

@DimitrisStaratzis let's make a slightly more elaborate description to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants