Merged
Conversation
robertbindar
requested review from
DimitrisStaratzis,
eddelbuettel,
johnkerl and
teo-tsirpanis
robertbindar
force-pushed
the
rbin/ch52192/add_ndrectangle_ndim
branch
from
cf65294 to
f712c9e
Compare
johnkerl
approved these changes
Aug 7, 2024
KiterLuc
changed the title
robertbindar
force-pushed
the
rbin/ch52192/add_ndrectangle_ndim
branch
from
f712c9e to
23dcfa0
Compare
eddelbuettel
approved these changes
Aug 8, 2024
Contributor
eddelbuettel
left a comment
eddelbuettel
left a comment
There was a problem hiding this comment.
Looks good to me -- as an API user I only access the one new dim_num() API member which does what it is supposed to do. I didn't have an urgent for it so this isn't unblocking or improving anything that waits for it but I will of course add an accessor once this is merged,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds capi and cppapi support for querying the number of slots/dimensions/axes of a current domain ndrectangle.
Depends on #5229 to be merged first.
TYPE: FEATURE
DESC: Add dim num support for ndrectangle.