Merged
Conversation
ypatia
force-pushed
the
yt/sc-49128/fix_curl_retries
branch
2 times, most recently
from
9cc3684 to
b647566
Compare
ypatia
force-pushed
the
yt/sc-49128/fix_curl_retries
branch
from
b647566 to
f35be0b
Compare
Contributor
|
Is there any changes needed related to |
Member
Author
Thanks for bringing this to my attention, I think this change is generic and applies to any retry with data stored in a |
shaunrd0
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug in the retry logic when a 503 is encountered while uploading data. Our curl client fails to reset its BufferList state back to zero in this case and we end up sending a bunch of garbage data to the cloud service.
This PR fixes the issue and adds a regression test that failed before and passes with the fix.
[sc-49128]
TYPE: BUG
DESC: Reset offsets in buffer list for retries