Conversation
We require CMake 3.21 at minimum, so all policies <= CMP0126 are already set to NEW.
KiterLuc
approved these changes
Feb 5, 2024
Contributor
KiterLuc
left a comment
KiterLuc
left a comment
There was a problem hiding this comment.
I'll approve this for now, but in the future, this should be divided into two PRs.
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
This PR removes some unused code, specifically: * A patch file that should have been removed in #4553. * The `EncryptionKeyValidation` class that is unused since #1197. * Setting CMake policies to NEW that are already set by `cmake_minimum_required(VERSION 3.21)` --- TYPE: NO_HISTORY (cherry picked from commit 49e8752)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some unused code, specifically:
builtin-baselineand remove most custom ports. #4553.EncryptionKeyValidationclass that is unused since Monster PR #1197.cmake_minimum_required(VERSION 3.21)TYPE: NO_HISTORY