[Backport release-2.13] Don't retry curl errors for REST#3725
Merged
ihnorton merged 1 commit intorelease-2.13from Dec 8, 2022
Merged
[Backport release-2.13] Don't retry curl errors for REST#3725ihnorton merged 1 commit intorelease-2.13from
ihnorton merged 1 commit intorelease-2.13from
Conversation
If we received a curl error we should not resubmit the original request. There are some curl errors that can occur after we have received partial results and we might have already deserialized and copied data into the user buffer. Retries resubmit the initial request not accounting for any partial state. --- TYPE: IMPROVEMENT DESC: Do not resubmit http requests for curl errors for REST requests
ihnorton
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 8c370ab from #3712