Skip to content

Commit 3092f6a

Browse files
committed
test(pi-background-terminals): force exit and serialize test files
On Windows the test runner intermittently lingered for minutes after all tests passed when a spawned shell handle outlived its test. Force exit after the suite finishes, and run files serially to sidestep the open Node test-runner race (nodejs/node#64833) where --test-force-exit with concurrency can silently drop verdicts.
1 parent 97c8031 commit 3092f6a

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@tian.zuo/pi-background-terminals": patch
3+
---
4+
5+
Force exit after the background-terminal test suite finishes and run test files serially. On Windows the test runner could linger for many minutes after all tests passed when a spawned shell handle outlived its test, and the serial run avoids the open Node test-runner race (nodejs/node#64833) where `--test-force-exit` with concurrency can drop verdicts.

‎packages/pi-background-terminals/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"scripts": {
3939
"check": "tsc --noEmit -p .",
4040
"prepare": "effect-tsgo patch",
41-
"test": "node --test --experimental-strip-types index.test.ts manager.test.ts output.test.ts prompt.test.ts command-shape.test.ts result-delivery.test.ts ps.test.ts spill-source.test.ts"
41+
"test": "node --test --test-force-exit --test-concurrency=1 --experimental-strip-types index.test.ts manager.test.ts output.test.ts prompt.test.ts command-shape.test.ts result-delivery.test.ts ps.test.ts spill-source.test.ts"
4242
},
4343
"dependencies": {
4444
"effect": "4.0.0-beta.101"

0 commit comments

Comments
 (0)