Skip to content

qaci: add Python 3.14 in unittest#328

Merged
cocolato merged 2 commits intoThriftpy:masterfrom
lexdene:chore_python_314
Oct 14, 2025
Merged

qaci: add Python 3.14 in unittest#328
cocolato merged 2 commits intoThriftpy:masterfrom
lexdene:chore_python_314

Conversation

@lexdene
Copy link
Copy Markdown
Contributor

@lexdene lexdene commented Oct 11, 2025

No description provided.

@aisk
Copy link
Copy Markdown
Member

aisk commented Oct 11, 2025

Our tests depends on fork start method for multiprocessing module, and it seems Python3.14 changed it to other start method.

I have already fixed it in #326, so I think you can simply rebase this PR to the master branch to fix this.

@lexdene lexdene closed this Oct 13, 2025
@lexdene lexdene deleted the chore_python_314 branch October 13, 2025 02:36
@lexdene
Copy link
Copy Markdown
Contributor Author

lexdene commented Oct 13, 2025

Thank you for your fix.
I submitted another 2 issues about Python 3.14 just now.

@aisk
Copy link
Copy Markdown
Member

aisk commented Oct 13, 2025

I think this PR shouldn't be closed, you can just rebase or merge the current master branch and push it to this branch, the CI should be fixed.

@lexdene lexdene restored the chore_python_314 branch October 14, 2025 03:22
@lexdene lexdene reopened this Oct 14, 2025
@lexdene lexdene marked this pull request as ready for review October 14, 2025 03:38
@cocolato
Copy link
Copy Markdown
Member

I suggest adding 3.14t version to the CI as well.

@cocolato cocolato self-requested a review October 14, 2025 06:18
@cocolato cocolato merged commit c37c1e0 into Thriftpy:master Oct 14, 2025
25 checks passed
@lexdene lexdene deleted the chore_python_314 branch October 14, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants