Skip to content

Resolve daemon warnings for threading methods#306

Merged
aisk merged 1 commit intoThriftpy:masterfrom
emmanuel-ferdman:master
Apr 17, 2025
Merged

Resolve daemon warnings for threading methods#306
aisk merged 1 commit intoThriftpy:masterfrom
emmanuel-ferdman:master

Conversation

@emmanuel-ferdman
Copy link
Copy Markdown
Contributor

PR Summary

PR resolves the threading daemon warnings which you can find in the CI logs:

/tmp/thriftpy2/tests/test_framed_transport.py:75: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
    self.server_thread.setDaemon(True)

@ethe
Copy link
Copy Markdown
Member

ethe commented Apr 17, 2025

it looks good to me.

@ethe ethe requested a review from aisk April 17, 2025 02:56
@aisk aisk merged commit e9bbcfc into Thriftpy:master Apr 17, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants