Repository navigation
fix: support PEP 508 extras-qualified pins in dependency lock verification - #1007
Merged
pengfei-threemoonslab merged 2 commits intoOct 9, 2026
Merged
pengfei-threemoonslab merged 2 commits into
pengfei-threemoonslab merged 2 commits into
Conversation
1 of 2 tasks
pengfei-threemoonslab
approved these changes
Oct 10, 2026
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #500.
Summary
Updates the
_PINregex inscripts/verify_dependency_lock.pyto capture bracketed extras ((?P<extras>\[[^\]]+\])?) alongside package names.parse_lockis updated to gracefully extract these extras, apply PEP 508 canonicalization equivalent topackaging.requirements.Requirement(normalize_name_with_extras), and append them to the base name.This correctly parses configurations like
pydantic[email]==2.13.5 \as a unique and valid identity instead of rejecting it, while maintaining existing functionality for plain pins and direct URLs.Type
Authorship
Verification
CI is authoritative for
python -m ruff check .,python -m compileall -q src tests, andpython -m pytest.Additional local checks run:
4 passed, 0 failed) checking combinations of valid pins, single/multi-extra, direct URLs, and duplicate detection.ruff checkpassed locally with no issues.pytest tests/test_release_pipeline.pysuite reported 189 passed and 7 failed. The 7 failures are known environment incompatibilities executing theallowlist.shbash script on Windows, wholly unrelated to Python lock parsing.Release-readiness notes
docs/checks.mdSTABILITY.md