You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit aa6b126
Browse filesBrowse the repository at this point in the historyBrowse files
fix(agent-mode): drop the edit variant and close the remaining setup findings (#323)
Addresses the third and fourth review rounds on #372. Two of the eleven threads
were structural and both are resolved by taking scope *out* rather than adding
more.
**The typed `edit` action is removed.** Bumping the compatibility floor did not
answer the objection: `CodingAgentAction` is embedded by the verifier, the
handoff, preflight, the agent result, the boundary result, and verify-run, so
widening it widened six durable published schemas under unchanged identifiers —
and five of those artifacts record no `contract_version`, so a consumer holding
a stored payload cannot use a runtime floor to tell which shape it has. All six
are now byte-identical to `main` again, as is the frozen codex projection, and
`MINIMUM_CONTROL_CONTRACT_VERSION` returns to 21 with the adoption-kit chain it
had dragged along. A setup step that needs a file changed routes as a
`configure` command naming the check that confirms it, with the file in `why`
and structurally in `next_actions[].path` — which is where `docs/diagnostics.md`
has always published a path, and is how every other producer in this system
routes agent work.
**`scan` is out of the rollout, and the claims now say so.** The verdict lift
was withdrawn last round; what remained was a PR and a set of documents still
claiming #323 was closed for six commands. `AGENTS.md`, `STABILITY.md`,
`docs/agent-contract-current.md`, and the CHANGELOG now state that `scan`
publishes no verdict and that #323's scan half stays open until a complete,
reconfirmable input snapshot is threaded through report generation and pointer
publication. The two misleading messages are corrected: a SARIF-only scan does
bind a machine-readable artifact carrying the verdict, so the envelope says the
verdict is *withheld*, never that none exists.
The rest:
- `init` validates the existing manifest before reporting `setup_complete`. An
empty `shipgate.yaml` has no placeholders in it, so the refresh path called it
configured and handed back a verify command that exits 2 on the same file.
- `doctor`'s error paths carry the envelope. An invalid manifest printed nothing
on stdout and a legacy line on stderr; a valid HITL manifest whose declared
trace path is still `CHANGE_ME` failed while opening that literal path, before
ownership was evaluated, losing the field, the line, and the fact that a person
owes the value.
- `detect` lets an adopted root settle an ambiguous scope. `--allow-unresolved-scope`
is a decision, and re-asking on the next run made it unrepeatable.
- `init`'s dry-run advance repeats the setup flags it was given. The bare
`init --write` it emitted dropped `--ci`, the instruction selection, and
`--allow-unresolved-scope` — the last of which makes the command exit 2 in the
monorepo that needed it.
- `inspect_sources` reads the manifest once and parses those bytes. Loading the
path and then reopening it was two generations, so doctor could route from
manifest A under an identity hashing manifest B.
- `_placeholder_review_why` splits on both path separators and bounds the prefix
twice, so a long Windows path can no longer push the line number and field name
out of the only human action.
- `init`'s `input_id` covers the #370 scope facts, so a changed candidate list
moves the identity of the answer about it.
- `.well-known` publishes the real floor, pinned by a parity test against the
runtime contract, and the stale Codex-integration prerequisite is corrected.
Co-Authored-By: Claude Opus 5 <[email protected]>
Copy file name to clipboardExpand all lines: .agents/skills/agents-shipgate/SKILL.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -15,7 +15,7 @@ Do not use it for general linting, runtime monitoring, evals, model-output quali
15
15
16
16
1. For local checks, verifier runs, host audits, and supporting recovery commands, read `references/recipes.md`.
17
17
2. For reading `report.json`, summarizing release decisions, or deciding what may be auto-applied, read `references/report-reading.md`.
18
-
3. Before running Shipgate CLI commands, require a CLI whose `agents-shipgate contract --json` reports `minimum_control_contract_version: 24`: run `command -v agents-shipgate`, `agents-shipgate --version`, and `agents-shipgate contract --json`. If it is missing or stale, tell the user to install or upgrade `agents-shipgate`. The Codex plugin supplies workflows, not the scanner binary.
18
+
3. Before running Shipgate CLI commands, require a CLI whose `agents-shipgate contract --json` reports `minimum_control_contract_version: 21`: run `command -v agents-shipgate`, `agents-shipgate --version`, and `agents-shipgate contract --json`. If it is missing or stale, tell the user to install or upgrade `agents-shipgate`. The Codex plugin supplies workflows, not the scanner binary.
19
19
4. Set `AGENTS_SHIPGATE_AGENT_MODE=1` before running Shipgate commands so errors include structured `next_action` JSON.
20
20
5. Default first-time CI to advisory mode. Do not enable release-blocking CI or save a baseline until a human has reviewed current findings.
21
21
6. For local agent control, run `shipgate check --agent codex --workspace . --format agent-boundary-json` and read the stdout `shipgate.agent_boundary_result/v2` object. Switch on `control.state`; follow only `control.next_action`, `control.allowed_next_commands`, and `control.human_review`. Treat `decision` as diagnostic context only.
@@ -26,7 +26,7 @@ Do not use it for general linting, runtime monitoring, evals, model-output quali
26
26
27
27
## Fast Paths
28
28
29
-
- CLI preflight: run `command -v agents-shipgate`, `agents-shipgate --version`, and `agents-shipgate contract --json`. Continue only when the installed CLI reports `minimum_control_contract_version: 24`; if it is missing or stale, ask the user to install or upgrade `agents-shipgate`.
29
+
- CLI preflight: run `command -v agents-shipgate`, `agents-shipgate --version`, and `agents-shipgate contract --json`. Continue only when the installed CLI reports `minimum_control_contract_version: 21`; if it is missing or stale, ask the user to install or upgrade `agents-shipgate`.
30
30
- Agent-native check: run `shipgate check --agent codex --workspace . --format agent-boundary-json`; read only the JSON result for routing. Four shapes: continue, repair, verify-and-report (a graded `require_review` set — finish the work, then name every `pending_review[]` item in the summary), and stop.
31
31
- Agent-related PR/CI diff: run `agents-shipgate verify --workspace . --config shipgate.yaml --base origin/main --head HEAD --ci-mode advisory --format json` after making the base ref available. For local uncommitted work, omit `--base`/`--head` so the working tree is scanned. `verify` never fetches.
0 commit comments