Repository navigation
feat(ui): add animated loading state to data export button - #554
Merged
Merged
Conversation
|
@Furox-Art is attempting to deploy a commit to the Vicky's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Welcome to PACT OS, @Furox-Art! 🚀Thank you for taking the time to open your first pull request on PACT! We are thrilled to have you here in our open-source community. 🔍 What Happens Next?
📚 Helpful Quick Links
Thank you for helping make PACT better! Plan. Track. Improve. Repeat. 🏛️✨ |
Closes #500 Generating a workspace data export fans out across every user-owned domain and can take several seconds, so DataExportButton now reports progress while the request is in flight: - animated spinner (Loader2) plus an indeterminate gold progress bar that eases toward a 90% ceiling and settles at 100% on completion, never claiming done before the archive exists - the button stays disabled for the whole request, blocking duplicate exports; an early return in the handler guards re-entry too - role=progressbar with aria-valuenow, role=status aria-live for stage changes, and a success/error state with an icon and message Pure helpers (progress math, filename resolution) live in data-export-helpers.ts so the suite runner can exercise them without JSX; tests/data-export-button.test.ts covers the ticker, clamping and Content-Disposition parsing.
Furox-Art
force-pushed
the
ui/data-export-loading-state
branch
from
October 11, 2026 13:46
58b9b60 to
0cfd2bb
Compare
TheVicky1
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #500
What
DataExportButtonnow shows an animated loading state while the export archive is generated:Loader2spinner and an indeterminate gold progress bar render while the request is in flight. The bar eases toward a 90% ceiling (nextExportProgress) and settles at 100% when the archive resolves — it never claims completion before the file exists.role="progressbar"with livearia-valuenow; stage changes are announced through arole="status" aria-live="polite"region. Success and failure each get an icon and a message, then the control returns to idle.Acceptance criteria
npm testpasses without errorsStructure
The pure helpers (
nextExportProgress,clampExportProgress,resolveExportFilename,EXPORT_PROGRESS_CEILING) live insrc/components/settings/data-export-helpers.tsrather than inside the.tsx— the repo's suite runner parses plain.tsbut not JSX, and keeping the math pure makes it directly testable.tests/data-export-button.test.tscovers the ticker (advance, ceiling, monotonicity), clamping, and Content-Disposition parsing (quoted, unquoted, absent, malformed).Verification
npx tsc --noEmitis clean.