You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a5c569e
Browse filesBrowse the repository at this point in the historyBrowse files
Fixes doc comment references that the analyzer can't resolve, found by
temporarily enabling the `comment_references` lint.
Most are renames — the reference named a member that had been renamed,
made private, or removed. Four are judgement calls rather than renames,
so flagging them - happy to change any:
- `widgets/_window.dart` — removed a sentence describing the `if
(!isWindowingEnabled) { return widget.child; }` path deleted in
[flutter#188866](flutter#188866). The `{@macro
flutter.widgets.windowing.experimental}` later in the same comment
already documents the windowing-disabled case.
- `widgets/_window.dart` — constructor doc repointed from the removed
`child` to `initialWindows`.
- `widgets/_window_win32.dart` — removed "This can be overridden via the
`[WindowingOwnerWin32.test]` constructor.". `git log -S
"WindowingOwnerWin32.test("` finds no commit that added that
constructor.
- `rendering/viewport.dart` — `[Viewport.slivers]` isn't a member;
`slivers` is a constructor parameter forwarded to `super(children:
slivers)`. We cannot reference another class's constructor parameter, so
this became `[Viewport]`'s `slivers`.
Towards flutter#192870
0 commit comments