Skip to content

Commit 94a910d

Browse files
authored
Run gradient e2e benchmarks on Windows CI (flutter#191024)
Related: flutter#190401 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent a08cda8 commit 94a910d

6 files changed

Lines changed: 89 additions & 3 deletions

‎.ci.yaml‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7260,6 +7260,48 @@ targets:
72607260
]
72617261
task_name: windows_home_scroll_perf__timeline_summary
72627262

7263+
- name: Windows windows_gradient_consistent_perf__e2e_summary
7264+
recipe: devicelab/devicelab_drone
7265+
presubmit: false
7266+
bringup: true
7267+
timeout: 60
7268+
properties:
7269+
tags: >
7270+
["devicelab", "hostonly", "windows"]
7271+
dependencies: >-
7272+
[
7273+
{"dependency": "vs_build", "version": "version:vs2019"}
7274+
]
7275+
task_name: windows_gradient_consistent_perf__e2e_summary
7276+
7277+
- name: Windows windows_gradient_dynamic_perf__e2e_summary
7278+
recipe: devicelab/devicelab_drone
7279+
presubmit: false
7280+
bringup: true
7281+
timeout: 60
7282+
properties:
7283+
tags: >
7284+
["devicelab", "hostonly", "windows"]
7285+
dependencies: >-
7286+
[
7287+
{"dependency": "vs_build", "version": "version:vs2019"}
7288+
]
7289+
task_name: windows_gradient_dynamic_perf__e2e_summary
7290+
7291+
- name: Windows windows_gradient_static_perf__e2e_summary
7292+
recipe: devicelab/devicelab_drone
7293+
presubmit: false
7294+
bringup: true
7295+
timeout: 60
7296+
properties:
7297+
tags: >
7298+
["devicelab", "hostonly", "windows"]
7299+
dependencies: >-
7300+
[
7301+
{"dependency": "vs_build", "version": "version:vs2019"}
7302+
]
7303+
task_name: windows_gradient_static_perf__e2e_summary
7304+
72637305
- name: Windows windows_text_shadow_perf__timeline_summary
72647306
recipe: devicelab/devicelab_drone
72657307
presubmit: false

‎TESTOWNERS‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,9 @@
330330
/dev/devicelab/bin/tasks/windowing_test_windows.dart @mattkae @flutter/desktop
331331
/dev/devicelab/bin/tasks/windows_desktop_impeller.dart @jonahwilliams @flutter/engine
332332
/dev/devicelab/bin/tasks/windows_engine_integration_golden_test.dart @b-luk @flutter/engine
333+
/dev/devicelab/bin/tasks/windows_gradient_consistent_perf__e2e_summary.dart @b-luk @flutter/engine
334+
/dev/devicelab/bin/tasks/windows_gradient_dynamic_perf__e2e_summary.dart @b-luk @flutter/engine
335+
/dev/devicelab/bin/tasks/windows_gradient_static_perf__e2e_summary.dart @b-luk @flutter/engine
333336
/dev/devicelab/bin/tasks/windows_home_scroll_perf__timeline_summary.dart @jonahwilliams @flutter/engine
334337
/dev/devicelab/bin/tasks/windows_text_shadow_perf__timeline_summary.dart @gaaclarke @flutter/engine
335338
/dev/devicelab/bin/tasks/windows_startup_test.dart @loic-sharma @flutter/desktop
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
// Copyright 2014 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:flutter_devicelab/framework/devices.dart';
6+
import 'package:flutter_devicelab/framework/framework.dart';
7+
import 'package:flutter_devicelab/tasks/perf_tests.dart';
8+
9+
Future<void> main() async {
10+
deviceOperatingSystem = DeviceOperatingSystem.windows;
11+
await task(createGradientConsistentPerfE2ETest(createPlatforms: <String>['windows']));
12+
}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
// Copyright 2014 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:flutter_devicelab/framework/devices.dart';
6+
import 'package:flutter_devicelab/framework/framework.dart';
7+
import 'package:flutter_devicelab/tasks/perf_tests.dart';
8+
9+
Future<void> main() async {
10+
deviceOperatingSystem = DeviceOperatingSystem.windows;
11+
await task(createGradientDynamicPerfE2ETest(createPlatforms: <String>['windows']));
12+
}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
// Copyright 2014 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:flutter_devicelab/framework/devices.dart';
6+
import 'package:flutter_devicelab/framework/framework.dart';
7+
import 'package:flutter_devicelab/tasks/perf_tests.dart';
8+
9+
Future<void> main() async {
10+
deviceOperatingSystem = DeviceOperatingSystem.windows;
11+
await task(createGradientStaticPerfE2ETest(createPlatforms: <String>['windows']));
12+
}

‎dev/devicelab/lib/tasks/perf_tests.dart‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -608,24 +608,29 @@ TaskFunction createOpacityPeepholeColOfAlphaSaveLayerRowsPerfE2ETest() {
608608
).run;
609609
}
610610

611-
TaskFunction createGradientDynamicPerfE2ETest() {
611+
TaskFunction createGradientDynamicPerfE2ETest({List<String> createPlatforms = const <String>[]}) {
612612
return PerfTest.e2e(
613613
'${flutterDirectory.path}/dev/benchmarks/macrobenchmarks',
614614
'test/gradient_dynamic_perf_e2e.dart',
615+
createPlatforms: createPlatforms,
615616
).run;
616617
}
617618

618-
TaskFunction createGradientConsistentPerfE2ETest() {
619+
TaskFunction createGradientConsistentPerfE2ETest({
620+
List<String> createPlatforms = const <String>[],
621+
}) {
619622
return PerfTest.e2e(
620623
'${flutterDirectory.path}/dev/benchmarks/macrobenchmarks',
621624
'test/gradient_consistent_perf_e2e.dart',
625+
createPlatforms: createPlatforms,
622626
).run;
623627
}
624628

625-
TaskFunction createGradientStaticPerfE2ETest() {
629+
TaskFunction createGradientStaticPerfE2ETest({List<String> createPlatforms = const <String>[]}) {
626630
return PerfTest.e2e(
627631
'${flutterDirectory.path}/dev/benchmarks/macrobenchmarks',
628632
'test/gradient_static_perf_e2e.dart',
633+
createPlatforms: createPlatforms,
629634
).run;
630635
}
631636

0 commit comments

Comments
 (0)