Repository navigation
Commit 915812c
authored
[flutter_tools] Add tests for negative lookahead regex in test runner and batch entrypoints (flutter#191438)
## Description
Fixes flutter#84270
The root cause of flutter#84270 (delayed variable expansion in batch scripts
stripping `!` from CLI arguments like `^(?!Golden).+`) was previously
addressed in flutter#106861, which removed `SETLOCAL ENABLEDELAYEDEXPANSION`
from `bin/flutter.bat`, `bin/dart.bat`, and `bin/internal/shared.bat`.
However, flutter#84270 was left open without dedicated regression tests. This
PR:
1. Adds a hermetic unit test in `test_test.dart` verifying that
`TestCommand` preserves and forwards negative lookahead regexes
(`^(?!Golden).+`) to `FlutterTestRunner`.
2. Adds a case-insensitive static test in `script_test.dart` asserting
that Windows entrypoint batch scripts do not enable delayed expansion.
3. Unskips and modernizes the integration test in
`variable_expansion_windows_test.dart` verifying that `bin/dart.bat`
preserves lookahead regexes on Windows.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/1 parent a3191ed commit 915812c
3 files changed
Lines changed: 59 additions & 20 deletions
File tree
- packages/flutter_tools/test
- commands.shard
- hermetic
- permeable
- integration.shard
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1757 | 1757 | | |
1758 | 1758 | | |
1759 | 1759 | | |
| 1760 | + | |
| 1761 | + | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
| 1765 | + | |
| 1766 | + | |
| 1767 | + | |
| 1768 | + | |
| 1769 | + | |
| 1770 | + | |
| 1771 | + | |
| 1772 | + | |
| 1773 | + | |
| 1774 | + | |
| 1775 | + | |
| 1776 | + | |
| 1777 | + | |
1760 | 1778 | | |
1761 | 1779 | | |
1762 | 1780 | | |
| |||
1771 | 1789 | | |
1772 | 1790 | | |
1773 | 1791 | | |
| 1792 | + | |
| 1793 | + | |
1774 | 1794 | | |
1775 | 1795 | | |
1776 | 1796 | | |
| |||
1817 | 1837 | | |
1818 | 1838 | | |
1819 | 1839 | | |
| 1840 | + | |
| 1841 | + | |
1820 | 1842 | | |
1821 | 1843 | | |
1822 | 1844 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
33 | 53 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
32 | 29 | | |
0 commit comments