Skip to content

Comments

Upload codecov for migration tests#1200

Merged
jonathangreen merged 2 commits intomainfrom
bugfix/codecov-migration-tests-3
Jun 20, 2023
Merged

Upload codecov for migration tests#1200
jonathangreen merged 2 commits intomainfrom
bugfix/codecov-migration-tests-3

Conversation

@jonathangreen
Copy link
Member

Description

This makes a couple changes to our codecov config:

This also makes sure the migration tests only run at the same time as our other tests. Otherwise codecov adds a second status that is always failing to the PR. See #1197 and #1199.

Motivation and Context

@RishiDiwanTT made me realize that we aren't currently uploading codecov reports for migration tests in this comment:
#1189 (comment)

This should make the codecov for #1189 look better once its merged @RishiDiwanTT.

How Has This Been Tested?

I did a bit of testing locally to make sure the regex exclusions seemed like they were working.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09 🎉

Comparison is base (fa9adf2) 89.85% compared to head (dcbd04f) 89.94%.

❗ Current head dcbd04f differs from pull request most recent head 3a63ebc. Consider uploading reports for the commit 3a63ebc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1200      +/-   ##
==========================================
+ Coverage   89.85%   89.94%   +0.09%     
==========================================
  Files         195      195              
  Lines       29267    29203      -64     
  Branches     6722     6714       -8     
==========================================
- Hits        26299    26268      -31     
+ Misses       1945     1912      -33     
  Partials     1023     1023              

see 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jonathangreen jonathangreen requested a review from a team June 15, 2023 14:33
Copy link
Contributor

@pcustic pcustic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@jonathangreen jonathangreen force-pushed the bugfix/codecov-migration-tests-3 branch from dcbd04f to 3a63ebc Compare June 20, 2023 12:31
@jonathangreen jonathangreen merged commit 3769939 into main Jun 20, 2023
@jonathangreen jonathangreen deleted the bugfix/codecov-migration-tests-3 branch June 20, 2023 12:52
dbernstein pushed a commit that referenced this pull request Jun 5, 2025
[//]: # (dependabot-start)
⚠️  **Dependabot is rebasing this PR** ⚠️ 

Rebasing might not happen immediately, so don't worry if this takes some
time.

Note: if you make any changes to this PR yourself, they will take
precedence over the rebase.

---

[//]: # (dependabot-end)

Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from
3.6.1 to 3.7.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst">pytest-xdist's
changelog</a>.</em></p>
<blockquote>
<h1>pytest-xdist 3.7.0 (2025-05-26)</h1>
<h2>Features</h2>
<ul>
<li>

<p><code>[#1142](pytest-dev/pytest-xdist#1142)
&lt;https://github.com/pytest-dev/pytest-xdist/issues/1142&gt;</code>_:
Added support for Python 3.13.</p>
</li>
<li>

<p><code>[#1144](pytest-dev/pytest-xdist#1144)
&lt;https://github.com/pytest-dev/pytest-xdist/issues/1144&gt;</code>_:
The internal <code>steal</code> command is now atomic - it unschedules
either all requested tests or none.</p>
<p>This is a prerequisite for group/scope support in the
<code>worksteal</code> scheduler, so test groups won't be broken up
incorrectly.</p>
</li>
<li>

<p><code>[#1170](pytest-dev/pytest-xdist#1170)
&lt;https://github.com/pytest-dev/pytest-xdist/issues/1170&gt;</code>_:
Add the <code>--px</code> arg to create proxy gateways.</p>
<p>Proxy gateways are passed to additional gateways using the
<code>via</code> keyword.
They can serve as a way to run multiple workers on remote machines.</p>
</li>
<li>

<p><code>[#1200](pytest-dev/pytest-xdist#1200)
&lt;https://github.com/pytest-dev/pytest-xdist/issues/1200&gt;</code>_:
Now multiple <code>xdist_group</code> markers are considered when
assigning tests to groups (order does not matter).</p>
<p>Previously, only the last marker would assign a test to a group, but
now if a test has multiple <code>xdist_group</code> marks applied (for
example via parametrization or via fixtures), they are merged to make a
new group.</p>
</li>
</ul>
<h2>Removals</h2>
<ul>

<li><code>[#1162](pytest-dev/pytest-xdist#1162)
&lt;https://github.com/pytest-dev/pytest-xdist/issues/1162&gt;</code>_:
Dropped support for EOL Python 3.8.</li>
</ul>
<h2>Trivial Changes</h2>
<ul>
<li>

<p><code>[#1092](pytest-dev/pytest-xdist#1092)
&lt;https://github.com/pytest-dev/pytest-xdist/issues/1092&gt;</code>_:
Update an error message to better indicate where users should go for
more information.</p>
</li>
<li>

<p><code>[#1190](pytest-dev/pytest-xdist#1190)
&lt;https://github.com/pytest-dev/pytest-xdist/issues/1190&gt;</code>_:
Switched to using a SPDX license identifier introduced in PEP 639.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/b561916eaf6ec0a8a448ed0bcc90a351ab3c58e3"><code>b561916</code></a>
Release 3.7.0</li>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/71bd3ede1982a65cf74cf248c0ba906fe6062ce7"><code>71bd3ed</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1204">#1204</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/65de0ab30e602a5f466b8746fcfff0cf0945b600"><code>65de0ab</code></a>
Join multiple xdist_group markers (<a
href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1201">#1201</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/199f949716792db8745a69444091f4d4fddae0e2"><code>199f949</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1202">#1202</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/b0215da1edf369d5b63b7811b41d750bb5ebb072"><code>b0215da</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1199">#1199</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/18e47853ed9272a87b9e6d29b1630f854d458d4a"><code>18e4785</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1198">#1198</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/731c05d86ad3a42e0b2e3d3b4c8cdd5e33e81988"><code>731c05d</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1197">#1197</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/16c5be32031f904a5f48c2cdbf3424f6528af3b0"><code>16c5be3</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1195">#1195</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/e03757a1d77805776babf6faa73b696ea36c001c"><code>e03757a</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1193">#1193</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-xdist/commit/f1d81a4402e611dca7ae5bf4b892decfef9d4f08"><code>f1d81a4</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1192">#1192</a>
from adamchainz/document_disabling</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pytest-xdist/compare/v3.6.1...v3.7.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pytest-xdist&package-manager=pip&previous-version=3.6.1&new-version=3.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants