Closed
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
+ Coverage 89.85% 89.94% +0.09%
==========================================
Files 195 195
Lines 29267 29203 -64
Branches 6722 6714 -8
==========================================
- Hits 26299 26268 -31
+ Misses 1945 1912 -33
Partials 1023 1023 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Closing this for same reason as #1197. I see the issue now. Will make another new pr to test 😓. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes a couple changes to our codecov config:
exclude_alsoa new config option for coverage that preserves the built in exclusions https://coverage.readthedocs.io/en/7.2.2/config.html#report-exclude-also...passraise NotImplementedErrorMotivation and Context
@RishiDiwanTT made me realize that we aren't currently uploading codecov reports for migration tests in this comment:
#1189 (comment)
This should make the codecov for #1189 look better once its merged @RishiDiwanTT.
How Has This Been Tested?
I did a bit of testing locally to make sure the regex exclusions seemed like they were working.
Checklist