Revert PR #980 temporarily, while we do further work on it#1103
Revert PR #980 temporarily, while we do further work on it#1103jonathangreen merged 2 commits intomainfrom
Conversation
We are seeing elevated errors due to the auth filtering happening in migration intact. We will do further work and reenable in a future PR.
jonathangreen
requested review from
RishiDiwanTT and
tdilauro
and removed request for
RishiDiwanTT
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1103 +/- ##
==========================================
- Coverage 89.73% 89.72% -0.01%
==========================================
Files 177 176 -1
Lines 28794 28753 -41
Branches 6623 6618 -5
==========================================
- Hits 25838 25800 -38
+ Misses 1936 1934 -2
+ Partials 1020 1019 -1
☔ View full report in Codecov by Sentry. |
|
@RishiDiwanTT I'll wait for you to take a look at this, then get it rolled out tomorrow if it looks okay to you. |
|
While this looks fine as a code commit, do we want to keep recording the errors in the DB as a form of downtime analysis of the third party APIs, while keeping the threshold number high (like 100k errors) so it never truly goes down? |
|
I think we can pull the data we need for analysis from our existing logs, so I'm going to merge this one and make a new ticket to do some analysis and revisit. |
3 participants
Description
We're seeing an elevated number of 5XX errors in production due to the auth disable that was added in #980.
Motivation and Context
Going to disable this temporarily while we work out how we want to move this forward.
I did a git revert the PR and then modified it to keep the migration and new models in the code base, since they have already been rolled out to production. This just reverts the code that actually records and processes the auth failures.
How Has This Been Tested?
Checklist