Skip to content
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

Conversation

@lyricidal
Copy link
Contributor

@lyricidal lyricidal commented Nov 22, 2019

Up to v1.0.4.4

Commit by commit to figure out the one causing connection issues.

DOWNLOAD_CONNECT_TIMEOUT changed from 10 to 30 because some file start only after 15 sec (see below).

Fetching boost_1_64_0.tar.bz2 from https://dl.bintray.com/boostorg/release/1.64.0/source/
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:15 --:--:--     0
100 76.7M  100 76.7M    0     0  1863k      0  0:00:42  0:00:42 --:--:-- 8136k
/home/gitianuser/bitcoin/depends/work/download/boost-1_64_0/boost_1_64_0.tar.bz2.temp: OK

bitcoin/bitcoin@e7a7245
We may eventually want to break out harfbuzz and build it in depends, but
for now just ensure that runtime dependencies don't depend on whether or not
harfbuzz was present on the builder.

bitcoin/bitcoin@f149e31
For normal users, --no-same-owner is default, but not so for root, where it is assumed that root can change ownership willy-nilly. This is not the case for privilege-limited container environments where we gaslight the process into thinking it's root.

bitcoin/bitcoin@89bee1b
Let a man use his builtins if he wants to! Also, removes the unnecessary assumption that pwd lives under /bin/pwd.

bitcoin/bitcoin@f7696e6
Some dependency sources were downloaded via http, even though https (SSL/TLS) options are available. Even if we potentially check the integrity of the downloaded files via hash comparison, we should make use of this additional security layer.

bdb.mk
fontconfig.mk
freetype.mk
libX11.mk
libXau.mk
libXext.mk
libxcb.mk
native_cctools.mk
native_cdrkit.mk
xcb_proto.mk
xextproto.mk
xproto.mk
xtrans.mk
zlib.mk

miniupnp was switched to official project mirror with SSL support

bitcoin/bitcoin@d8bc47f
Secondary dependencies don't need to be shared.

bitcoin/bitcoin@1420928
The file `qt/winshutdownmonitor.cpp` is for Windows only. Excluding it
on other systems prevents a linker warning about missing symbols at
compile time.
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
This is a small removal from a larger PR: PIVX-Project/PIVX#824
@lyricidal lyricidal added the DO NOT MERGE Needs additional testing, fixes, or might break something unexpectedly label Nov 22, 2019
These locks address compiler warnings when compiling with clang's
`-Wthread-safety-analysis`
…eady be executable

Add zip package to OSLibs
Use .zip instead of tar.xz
Exclude PoA Miner, packaged by itself in another .zip
Adjust filename to dapscoin-poa-minerd-$BUILD_TARGET.zip
"when running the wallet with -server and using walletpassphrase over the RPC server (not the GUI console), the wallet doesn't lock again when the timeout expires, it stays unlocked indefinitely..."
… flag setting

This fixes an issue where the flag could be inappropriately changed.
- Restore explorer icon
- Remove 2 unused icons
…s are nearly empty

Simple backport of bitcoin#6530

PIVX-Project/PIVX#798

Earlier, when there are only a few entries in the addrman tables, Select() could spin for long periods of time (~200ms), resulting in high CPU usage (up to 40% here). This reduces it to around 0.3ms (0.5% CPU).

(We have half of this commit for some reason, second half added)
fix getchaintips crash issue
…db function signatures

"Using throw() specifications in function signatures is not only not required in C++, it is considered deprecated for [various reasons] https://stackoverflow.com/questions/1055387/throw-keyword-in-functions-signature).
It is not implemented by any of the common C++ compilers. The usage is
also inconsistent with the rest of the source code."
fix gettransaction showing enormous transaction fees
(even though it is hidden)
… warnings

This removes redundant function declarations in the following files:
main.h
…cause of re-scanning

fix rescanning everytime issue
This is currently not hooked up, but prep for hiding orpans

Still requires a checkbox in the UI on our newer Settings page vs the older Options Dialog
@lyricidal lyricidal marked this pull request as ready for review November 24, 2019 04:14
@lyricidal lyricidal removed the DO NOT MERGE Needs additional testing, fixes, or might break something unexpectedly label Nov 24, 2019
@lyricidal lyricidal merged commit cf7d7f7 into multisig Nov 24, 2019
@lyricidal lyricidal deleted the DAPS-1330-multisig branch November 24, 2019 05:15
lyricidal added a commit that referenced this pull request Nov 24, 2019
* [TRIAL] fix multisig wallet not sync

* fix compilation errors

* genesis to restart devnet

* reduce PoW blocks to 200

* fix compilation error

* remove staking check in sendcoin diaglo

* add RPC to daemon to co-sign

* update multisig

* Don't allow resizing of Co-Signers window

* DAPS-1275 #comment disable auto-reconsolidation feature

* fix bug with connection port

* DAPS-1330 - Multisig [commit by commit] (#967)

* depends: allow CC/CXX to be overridden during configure

bitcoin/bitcoin@0d00fd5

* depends: Enable unicode support on bdb for Windows

bitcoin/bitcoin@5bb0164

* Scripts and tools: increased timeout downloading

DOWNLOAD_CONNECT_TIMEOUT changed from 10 to 30 because some file start only after 15 sec (see below).

Fetching boost_1_64_0.tar.bz2 from https://dl.bintray.com/boostorg/release/1.64.0/source/
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:15 --:--:--     0
100 76.7M  100 76.7M    0     0  1863k      0  0:00:42  0:00:42 --:--:-- 8136k
/home/gitianuser/bitcoin/depends/work/download/boost-1_64_0/boost_1_64_0.tar.bz2.temp: OK

bitcoin/bitcoin@e7a7245

* depends: Remove unused Qt 4 dependencies

bitcoin/bitcoin@7177e09

* depends: qt: avoid system harfbuzz and bz2

We may eventually want to break out harfbuzz and build it in depends, but
for now just ensure that runtime dependencies don't depend on whether or not
harfbuzz was present on the builder.

bitcoin/bitcoin@f149e31

* build: Remove illegal spacing in darwin.mk

bitcoin/bitcoin@63c74d2

* depends: expat 2.2.6

bitcoin/bitcoin@095e765

* depends: Preprocessing doesn't care about deps

bitcoin/bitcoin@80f0e05

* depends: Add commands for each package for each stage

bitcoin/bitcoin@6d44c5e

* depends: native_protobuf: avoid system zlib

bitcoin/bitcoin@19a0c4a

* depends: tar: Always extract as yourself

For normal users, --no-same-owner is default, but not so for root, where it is assumed that root can change ownership willy-nilly. This is not the case for privilege-limited container environments where we gaslight the process into thinking it's root.

bitcoin/bitcoin@89bee1b

* depends: qt: Don't hardcode pwd path

Let a man use his builtins if he wants to! Also, removes the unnecessary assumption that pwd lives under /bin/pwd.

bitcoin/bitcoin@f7696e6

* depends: switch to secure download of all dependencies

Some dependency sources were downloaded via http, even though https (SSL/TLS) options are available. Even if we potentially check the integrity of the downloaded files via hash comparison, we should make use of this additional security layer.

bdb.mk
fontconfig.mk
freetype.mk
libX11.mk
libXau.mk
libXext.mk
libxcb.mk
native_cctools.mk
native_cdrkit.mk
xcb_proto.mk
xextproto.mk
xproto.mk
xtrans.mk
zlib.mk

miniupnp was switched to official project mirror with SSL support

bitcoin/bitcoin@d8bc47f

* depends: Build secondary deps statically.

Secondary dependencies don't need to be shared.

bitcoin/bitcoin@1420928

* [Build] compile/link winshutdownmonitor.cpp on Windows only

The file `qt/winshutdownmonitor.cpp` is for Windows only. Excluding it
on other systems prevents a linker warning about missing symbols at
compile time.

* [QT] cleanup, remove old trading dialog form

* [Wallet] Remove (explicitely) unused tx comparator

We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.

* Fix compile error - unused code

This is a small removal from a larger PR: PIVX-Project/PIVX#824

* Resize About screen to properly fit DAPS

* Disable getstakingstatus, remove staking status from getinfo (avoid future conflicts)

* Bump version to v1.0.4

* a more sanitized check for received transaction: check commitment whenever receive a tranaction

b62a4f0

* customize transaction selection and fees to speed up transaction processing

* [Qt] Remove Growl support

[Qt] Remove Growl support

* [Refactor] Remove 'boost::lexical_cast<>

* Clean up apparent locking issues

These locks address compiler warnings when compiling with clang's
`-Wthread-safety-analysis`

* [Refactoring] Replace BOOST FOREACH with for :

-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp
./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-

* Bump version to v1.0.4.1

* Update tests to fix compile

* Comment out erroring tests (can be restored in future)

* Fix Multisig test

Somehow this one was reverted to the monosig test, restored previous fix by @pvc2104

* Cleanup clang's range loop analysis warnings

* [Qt] Add a security warning to the debug console's default output.

This adds a generic warning message to the debug console's initial
output, mentioning that the commands available should not be used
without prior understanding of what they do.

Also fixes the `clear` key combo displayed when on macOS.

* Increase LevelDB max_open_files unless on 32-bit Unix

This change significantly increases IBD performance by increasing the
amount of the UTXO index that can remain in memory. To ensure this
doesn't cause problems in the future, a static_assert on the LevelDB
version has been added, which must be updated by anyone upgrading
LevelDB.

* Stop using dummy strings in clientversion

This changes the "dummy" GIT_COMMIT_ID and GIT_COMMIT_DATE strings used in archive packages to use live values instead of static placeholders.

Useful when compiling in an isolated/base environment with an archive produced using make dist from a fully connected environment.

* [Wallet] Add missing variable to 2 AvailableCoins() calls

This is mostly depreciated code since the removal of coinjoin style
privacy (Obfuscation), but the missing boolean variable in these two
calls was causing compiler warnings on newer versions of gcc for always
evaluating to true.

The use of a static `false` was taken from upstream DASH.

* Add masternode's pubkey to listmasternodes RPC

Add the masternode's public key (used to broadcast masternode messages) to listmasternodes RPC. I could not find another convenient way to get a masternode's public key (which is public information needed to validate masternode messages) from the RPC calls.

* [RPC] Fix verifychain

verifychain only accepts a single (optional) argument instead of two,
and we need to capture that argument properly.

* Remove the no longer supported obfuscation RPC command

* Remove time-based version disconnect

Now that the time has passed for the tiered disconnect, we can make it a blanket ban of older versions, regardless of timestamp.

* DAPS-1284 increase relay transaction buffer size to 50kb

* DAPS-1258 Linux binaries in the publicly downloadable ZIPs should already be executable

Add zip package to OSLibs
Use .zip instead of tar.xz
Exclude PoA Miner, packaged by itself in another .zip
Adjust filename to dapscoin-poa-minerd-$BUILD_TARGET.zip

* DAPS-942 copy only secret key for 2fa

* Bump version to v1.0.4.2

* DAPS-1260 - Qt > Tools: Typo in description of Wallet Repair tab

Fix typo

* DAPS-761 From PIVX: [RPC]: Fix RPCTimerInterface ordering issue

"when running the wallet with -server and using walletpassphrase over the RPC server (not the GUI console), the wallet doesn't lock again when the timeout expires, it stays unlocked indefinitely..."

* [RPC] fix typo in 'unlockwallet' help

* DAPS-1077 Rescan transactions after using mnemonic recovery phrase

* DAPS-1248 From PIVX: [Wallet] fix bug with fWalletUnlockAnonymizeOnly flag setting

This fixes an issue where the flag could be inappropriately changed.

* Bump version to v1.0.4.3

* DAPS-1290: QT: Icon for the 'block-explorer' menu item is missing

- Restore explorer icon
- Remove 2 unused icons

* DAPS-1305 from PIVX: Improve addrman Select() performance when buckets are nearly empty

Simple backport of bitcoin#6530

PIVX-Project/PIVX#798

Earlier, when there are only a few entries in the addrman tables, Select() could spin for long periods of time (~200ms), resulting in high CPU usage (up to 40% here). This reduces it to around 0.3ms (0.5% CPU).

(We have half of this commit for some reason, second half added)

* DAPS-1247 fix getchaintips crash issue

fix getchaintips crash issue

* DAPS-761 From PIVX: Remove deprecated throw() build warnings in leveldb function signatures

"Using throw() specifications in function signatures is not only not required in C++, it is considered deprecated for [various reasons] https://stackoverflow.com/questions/1055387/throw-keyword-in-functions-signature).
It is not implemented by any of the common C++ compilers. The usage is
also inconsistent with the rest of the source code."

* DAPS-1282 Fix gettransaction showing enormous transaction fees

fix gettransaction showing enormous transaction fees

* Fix taskbar menu spacing for Sync KeyImage

* Update Auto consolidate tooltip

(even though it is hidden)

* DAPS-761 From PIVX: Remove Redundant Declarations that cause compiler warnings

This removes redundant function declarations in the following files:
main.h

* DAPS-1077/1309 opening wallet in v1.0.4.3 take long time (5 -10 min) cause of re-scanning

fix rescanning everytime issue

* DAPS-761 From PIVX: Hide orphans [Not hooked up yet]

This is currently not hooked up, but prep for hiding orpans

Still requires a checkbox in the UI on our newer Settings page vs the older Options Dialog

* Daps 1242 rescanwallettransactions

* Bump version to v1.0.4.4

* Fix compile error
@DecentralizedSolutions DecentralizedSolutions added this to the v1.0.5 milestone Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants