fix(github): use the GraphQL endpoint on GitHub Enterprise Server - #4272

User description

What

pr_agent/git_providers/github_provider.py: the two raw GraphQL calls, the resolveReviewThread mutation in resolve_comment_thread() and the sub-issues query in fetch_sub_issues(), now go through a small _post_graphql() helper. It POSTs to the requester's graphql_url instead of the relative path "/graphql". On github.com the request is unchanged.

tests/unittest/test_github_graphql_endpoint.py: 4 new tests (2 functions, each for github.com and Enterprise Server). They drive a real PyGithub client over a stubbed requests.Session that serves GraphQL only at the documented endpoint, and assert the paths sent and the result. The fake requesters in three existing test files gained the graphql_url attribute that PyGithub's Requester has.

Why

PyGithub resolves a relative URL under the REST prefix of base_url. With the documented Enterprise Server setting GITHUB__BASE_URL=https://github.mycompany.com/api/v3 (docs/docs/installation/github.md), requestJson("POST", "/graphql") goes to /api/v3/graphql. GHES serves GraphQL at /api/graphql. That is the URL PyGithub's graphql_url derives from base_url (PyGithub/PyGithub#2880), and _review_thread_nodes() already reaches it through graphql_query().

So on GHES, within one resolve_comment_thread() call, the thread lookup reaches /api/graphql but the mutation goes to /api/v3/graphql. Reproduced on main with a real Github(base_url="https://github.mycompany.com/api/v3") client (PyGithub 2.10.0, the locked version), over a stub that serves GraphQL only at /api/graphql:

fetch_sub_issues       -> set()   sent: [('POST', '/api/v3/graphql')]
resolve_comment_thread -> False   sent: [('GET', '/api/v3/repos/owner/repo/pulls/comments/123'),
                                         ('POST', '/api/graphql'), ('POST', '/api/v3/graphql')]

The only log output is Issue ID not found for ... and Resolve mutation returned isResolved=false for thread PRRT_1 — possible permission issue. For GHES users this means:

• /ask_line with pr_questions.resolve_threads = true never resolves a thread, and the warning points at permissions.
• Ticket analysis (pr_reviewer.require_ticket_analysis_review, on by default) never adds the sub-issues of a linked issue.

With this branch the same script returns the sub-issue and True, and every GraphQL request goes to /api/graphql.

The calls keep requestJson rather than switching to graphql_query(). graphql_query() raises on any errors entry, and fetch_sub_issues() handles the NOT_FOUND payload for PR-number links without a traceback on purpose (TestFetchSubIssuesNullGraphQLFields).

Testing

• PYTHONPATH=. uv run pytest tests/unittest/test_github_graphql_endpoint.py -q: 4 passed. With only the github_provider.py change reverted: 2 failed (both Enterprise Server cases), 2 passed (github.com).
• PYTHONPATH=. uv run pytest tests/unittest/test_github_provider_comments.py tests/unittest/test_ticket_extraction_async.py tests/unittest/test_github_provider_exception_narrowing.py -q: 241 passed, both on this branch and with the fix reverted, so the fake changes do not alter what those tests check.
• PYTHONPATH=. uv run pytest tests/unittest -q: 14134 passed, 33 skipped. The other 46 failures and 1 error come from my offline sandbox, mostly tiktoken failing to download its encoding. Unmodified main fails the same 47 tests there, and none of them is a GitHub provider test.
• uv run ruff check on the five changed files: All checks passed. The pre-commit-hooks v6.0.0 checks from .pre-commit-config.yaml also pass on them.

All HTTP is stubbed; this was not run against a live GHES instance.

🤖 Generated with Claude Code

PR Type

Bug fix, Tests

Description

• Route GraphQL requests through PyGithub's derived endpoint.

• Fix Enterprise thread resolution and sub-issue retrieval.

• Test endpoint routing across GitHub deployment types.

• Update existing requester mocks for endpoint compatibility.

Diagram Walkthrough

flowchart LR
  A["Thread resolution and sub-issue retrieval"]
  B["_post_graphql helper"]
  C["PyGithub requester.graphql_url"]
  D["GitHub.com /graphql"]
  E["Enterprise Server /api/graphql"]
  A --> B
  B --> C
  C --> D
  C --> E