Repository navigation
refactor: centralize primary command descriptions - #3048
Conversation
IsmaelMartinez
left a comment
IsmaelMartinez
left a comment
There was a problem hiding this comment.
Thanks for turning this round the same day, and for covering the usage guides, which I had not thought to ask for.
Verified rather than read: the map is genuinely the single source, all five new tests go red with the three consumers restored to main, and the suite is 3620 passed. The new wording does reach the CLI help, all three branches of the /help table, and the usage guides appended to published /describe, /review and /improve bodies.
One inline note on the tools index.
IsmaelMartinez
left a comment
IsmaelMartinez
left a comment
There was a problem hiding this comment.
Thanks for restoring the table verbatim and revalidating on top of it. The code side is done from my end.
I diffed the restored table against my suggestion byte for byte and it matches, the five tests still go red with the three consumers reverted to main, and the full suite is 3620 passed with today's main merged in. The improve overview also no longer renders "improving the PR.The tool", which was a pre-existing bug.
One thing left: #3039 names six places and docs/docs/tools/{describe,review,improve}.md are untouched, so merging auto-closes it while describe.md now disagrees with the help.py overview it used to match. Align those three here, or switch Closes to Refs and I will take them separately.
Code Review by QodoSorry, something went wrongWe weren't able to complete the code review on our side. Please try again manually by commenting/agentic_review on this PR.
|
|
Addressed the remaining #3039 scope in 331df8e: the Overview text in |
IsmaelMartinez
left a comment
IsmaelMartinez
left a comment
There was a problem hiding this comment.
Thanks for closing the last gap. The three tool pages and the regression test now match the map, so #3039 can close with this.
Summary
/describe,/review, and/improveTesting
PYTHONPATH=. uv run pytest tests/unittest/test_command_descriptions.py tests/unittest/test_cli_plain_diff_mode.py tests/unittest/test_cli_config_branch.py -q(16 passed)uv run ruff check pr_agent/command_descriptions.py pr_agent/cli.py pr_agent/servers/help.py pr_agent/tools/pr_help_message.py tests/unittest/test_command_descriptions.pypython -m py_compile pr_agent/command_descriptions.py pr_agent/cli.py pr_agent/servers/help.py pr_agent/tools/pr_help_message.py tests/unittest/test_command_descriptions.pypython -X utf8 -m mkdocs build -f docs/mkdocs.ymlCloses #3039