Repository navigation
docs: make configuration defaults authoritative - #3000
Merged
IsmaelMartinez merged 2 commits intoSep 3, 2026
Merged
IsmaelMartinez merged 2 commits into
IsmaelMartinez merged 2 commits into
Conversation
Contributor
Author
|
/agentic_review |
IsmaelMartinez
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this is a clean sweep and all seven rotting configuration.toml#L anchors are gone.
Three asks inline. The first is the defect this issue exists to remove, in a cell you rewrote.
Contributor
IsmaelMartinez
approved these changes
Sep 3, 2026
IsmaelMartinez
left a comment
Collaborator
There was a problem hiding this comment.
Verified: 99ea0dd resolves all three. Re-ran the gate check against your fix: perplexity/sonar still catches the regression, confirming coverage holds. Nice turnaround. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configuration.tomlas the authoritative source for mutable defaultsCloses #2960.
Validation
PYTHONPATH=. .venv/Scripts/python.exe -m pytest tests/unittest/test_mosaico_health.py -q— 8 passedmkdocs build -f docs/mkdocs.yml— passed (repository-existing link/imaging warnings remain)git diff --check— passedThe aggregate
pre-commit run --files ...command could not initialize its remote hook environment because GitHub returned a port 443 timeout; the same pinned hook version was installed from PyPI and run directly instead.