Skip to content

docs: make configuration defaults authoritative - #3000

Merged
IsmaelMartinez merged 2 commits into
The-PR-Agent:mainfrom
Ricky-7-Yan:docs/issue-2960-default-source
Sep 3, 2026
Merged

IsmaelMartinez merged 2 commits into
The-PR-Agent:mainfrom
Ricky-7-Yan:docs/issue-2960-default-source

Conversation

@Ricky-7-Yan

Copy link
Copy Markdown
Contributor

Summary

  • point documentation at configuration.toml as the authoritative source for mutable defaults
  • replace line-number deep links with stable file links
  • remove duplicated default values from the review, describe, and improve option tables
  • decouple the MOSAICO health-test fixture from the shipped default model

Closes #2960.

Validation

  • PYTHONPATH=. .venv/Scripts/python.exe -m pytest tests/unittest/test_mosaico_health.py -q — 8 passed
  • mkdocs build -f docs/mkdocs.yml — passed (repository-existing link/imaging warnings remain)
  • Ruff check plus the v6 pre-commit hook entry points for AST, conflicts, case conflicts, symlinks, file endings, line endings, trailing whitespace, and debug statements — passed
  • git diff --check — passed

The aggregate pre-commit run --files ... command could not initialize its remote hook environment because GitHub returned a port 443 timeout; the same pinned hook version was installed from PyPI and run directly instead.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 2, 2026
@Ricky-7-Yan

Copy link
Copy Markdown
Contributor Author

/agentic_review

@IsmaelMartinez IsmaelMartinez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a clean sweep and all seven rotting configuration.toml#L anchors are gone.

Three asks inline. The first is the defect this issue exists to remove, in a cell you rewrote.

Comment thread docs/docs/tools/describe.md Resolved
Comment thread tests/unittest/test_mosaico_health.py Resolved
Comment thread docs/docs/tools/describe.md Resolved
@qodo-code-review

qodo-code-review Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Code Review by Qodo

Grey Divider

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again manually by commenting /agentic_review on this PR.

Grey Divider

Qodo Logo

@IsmaelMartinez IsmaelMartinez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: 99ea0dd resolves all three. Re-ran the gate check against your fix: perplexity/sonar still catches the regression, confirming coverage holds. Nice turnaround. Approving.

@IsmaelMartinez
IsmaelMartinez merged commit 53f5678 into The-PR-Agent:main Sep 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs restate configuration.toml values that then go stale

2 participants