update cmake to work with newer versions#2
Open
hiaselhans wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
update cmake to work with newer versions#2hiaselhans wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
hiaselhans wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
flokli
reviewed
Oct 6, 2025
| ENDIF() | ||
| PROJECT(${PROJECT_NAME} VERSION ${LEMON_VERSION}) | ||
|
|
||
| find_package(Python3 REQUIRED COMPONENTS Interpreter) |
There was a problem hiding this comment.
I pulled this patch to fix the lemon-graph build in nixpkgs, and noticed the only place python is actually used seems to be here:
lemon-graph/doc/CMakeLists.txt
Line 36 in f871b10
Maybe this can be made optional?
flokli
added a commit
to flokli/nixpkgs
that referenced
this pull request
Oct 6, 2025
Pull in The-OpenROAD-Project/lemon-graph#2. Upstream seems to be down (at least currently), and while this is an unofficial fork, the patch applies cleanly and fixes the build.
Member
|
Sorry this got lost and not reviewed. I only noticed it while merging #4 . That seems rather similar though not identical. If you want to resolve the conflicts we can merge this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the build on newer cmake versions.
I removed the logic to get the version string from the mercurial repo, since there is onlz a git repo left.