Skip to content

#2049 Full auto in the sidebar is a label and a switch, nothing else - #68

Merged
polymaniadeveloper-hub merged 2 commits into
masterfrom
delivery/2049-full-auto-in-the-sidebar-is-a-label-and--d678f34296
Oct 27, 2026
Merged

polymaniadeveloper-hub merged 2 commits into
masterfrom
delivery/2049-full-auto-in-the-sidebar-is-a-label-and--d678f34296

Conversation

@polymaniadeveloper-hub

Copy link
Copy Markdown
Collaborator

Task pingdotgg#2049, run run-d678f34296. Approved by full auto, turned on by T at 2026-10-25T02:20:17.172Z for commit 2414f1e, which passed its checks and the QA gate.

No person signed this off: full auto approved it, on the switch T turned on at 2026-10-25T02:20:17.172Z.

What was asked

The owner's request: the sidebar's Full auto control takes too much room. Show only "Full auto on" or "Full auto off" and the switch.

Today (apps/web/src/components/delivery/ApprovalControls.tsx, the showAuto block) it also shows "Turned on by T, since 25/10/2026, 09:20:17" and a "Turn off" button. The button sends /api/engine/auto/off, which is what turning the switch off already does, so it is a second control for the same thing.

Done when:

  1. In the sidebar (SidebarApprovalControls in SidebarChrome.tsx) the control is the label and the switch, on one row. No "Turned on by / since" text and no "Turn off" button.
  2. Turning the switch off turns full auto off, as now, with no passphrase. Turning it on still goes through the existing warning and passphrase dialog.
  3. Who turned it on, and since when, stay visible in the engine panel (EnginePanel.tsx, which uses the same ApprovalControls), so nothing is lost. The engine panel has no "Turn off" button either; its switch does that.
  4. The phone portrait sidebar fits the control on one line.

Reuse: the existing Switch, the existing warning and passphrase dialog. Nothing new.

Done when

  1. With Full auto on, the web sidebar's Full auto control is the 'Full auto on' label and the switch on one row: no 'Turned on by / since' text and no 'Turn off' button.
  2. Turning the switch off posts /api/engine/auto/off with no passphrase and turns Full auto off, as today; turning it on still opens the existing warning dialog, then the passphrase dialog, and submits with the passphrase.
  3. In the engine panel, with Full auto on, the 'Turned on by …, since …' attribution is still shown, and the engine panel has no 'Turn off' button either.
  4. At a phone portrait viewport, the sidebar's Full auto control fits on a single line (label and switch do not wrap).
  5. The ApprovalControls unit tests pass (pnpm exec vp test run apps/web/src/components/delivery/ApprovalControls.test.tsx) after updating the assertions that referenced the removed text and button.

Opened by the delivery engine for full auto, turned on by T at 2026-10-25T02:20:17.172Z. Merging is a separate step.

delivery engine added 2 commits October 27, 2026 01:16
Sidebar Full auto now shows only its nonwrapping label and switch. Engine attribution remains visible. Removed the redundant Turn off button from both variants; activation and deactivation handlers are unchanged.

Task task-d2effc5a42, revision 2, run run-d678f34296.
Completed the build follow-up: fixed lint failures while preserving the compact sidebar control, engine attribution, and existing Switch and warning/passphrase dialog.

Task task-d2effc5a42, revision 2, run run-d678f34296.
@polymaniadeveloper-hub
polymaniadeveloper-hub merged commit c6dded7 into master Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant