feat: add parameter for HttpRequestMessage#461
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for matching HttpRequestMessage parameters in Mockolate’s web helpers, and wires up HttpClient mocking to allow SendAsync setups using the new request matcher.
Changes:
- Introduced
It.IsHttpRequestMessage(HttpMethod? method = null)fluent parameter with URI/content/header sub-matchers. - Added
HttpClientExtensions.SendAsync(IParameter<HttpRequestMessage>)setup helper targetingHttpMessageHandler.SendAsync. - Added/updated unit tests and API snapshot expectations for the new API surface.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpRequestMessageTests.cs | Adds method-matching tests for IsHttpRequestMessage(method) |
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpRequestMessageTests.WithHeadersTests.cs | Adds header matching tests for request/content/default headers |
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpRequestMessageTests.WhoseUriIsTests.cs | Adds URI matching tests for request matcher |
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpRequestMessageTests.WhoseStringContentIsTests.cs | Adds string-body/media-type matching tests for request content |
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpRequestMessageTests.WhoseContentIsTests.cs | Adds content media-type matching coverage |
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpRequestMessageTests.WhoseBinaryContentIsTests.cs | Adds binary/body/media-type matching coverage |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_netstandard2.0.txt | Updates API snapshot for new request matcher + SendAsync overload |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_net8.0.txt | Updates API snapshot for new request matcher + SendAsync overload |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_net10.0.txt | Updates API snapshot for new request matcher + SendAsync overload |
| Source/Mockolate/Web/ItExtensions.cs | Adjusts header matcher API and header matching to include alternative headers |
| Source/Mockolate/Web/ItExtensions.HttpRequestMessage.cs | Adds request matcher parameter + fluent configuration |
| Source/Mockolate/Web/ItExtensions.HttpContent.cs | Adjusts header matcher API for content parameters |
| Source/Mockolate/Web/HttpClientExtensions.cs | Adds SendAsync(IParameter<HttpRequestMessage>) setup path via mocked handler |
🚀 Benchmark ResultsDetails
|
|
|
This is addressed in release v1.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for matching
HttpRequestMessageparameters in Mockolate’s web helpers, and wires up HttpClient mocking to allowSendAsyncsetups using the new request matcher.Key Changes:
It.IsHttpRequestMessage(HttpMethod? method = null)fluent parameter with URI/content/header sub-matchers.HttpClientExtensions.SendAsync(IParameter<HttpRequestMessage>)setup helper targetingHttpMessageHandler.SendAsync.WithHeaderstoHttpRequestMessageparameter #458