Repository navigation
fix(container): propagate host project lookup errors - #3611
Merged
lyingbug merged 1 commit intoSep 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hostProjectLookupImpl.ProjectDirForSessionwas treating every GORM query error as an unbound session. That makes a cancelled or otherwise failed lookup indistinguishable fromgorm.ErrRecordNotFound, so the workspace resolver can allocate a replacement session directory instead of failing closed.This change keeps the existing unbound behavior only for
gorm.ErrRecordNotFoundand returns all other database/query errors to the resolver. It also adds a regression test for an already-cancelled context.Type of Change
Related Issue
Fixes #3609
Testing
go test -tags desktop ./internal/container/host_project_lookup.go ./internal/container/host_project_lookup_test.go -run '^TestProjectLookupPropagatesDatabaseErrors$' -count=1go test -tags desktop ./internal/container/host_project_lookup.go ./internal/container/host_project_lookup_test.go -run 'TestProjectLookup(FailsClosedWhenDirectoryRevoked|EmptyHostWorkspaceDirIsUnbound|ReturnsFalseForUnknownSession|PropagatesDatabaseErrors)$' -count=1go vet -tags desktop ./internal/container/host_project_lookup.go ./internal/container/host_project_lookup_test.gogofmtandgit diff --checkThe focused tests pass locally. The full package run on this Windows host has an unrelated baseline failure because the existing approved-directory test uses POSIX paths; the same package is run by the repository's Ubuntu CI workflow.